This repository has been archived by the owner on Dec 10, 2024. It is now read-only.
Exports: KiCAD schematic roundtrip #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mawildoer
force-pushed
the
mawildoer/kicad-schematic-exporter-4
branch
from
0ef533c to
668380c
Compare
mawildoer
changed the title
mawildoer
commented
Sep 13, 2024
mawildoer
changed the title
mawildoer
changed the title
|
Sweet. Thanks for the review. Can do on the last suggestion. Positional doesn't work because it at least appears to always be the last item, so I could maybe modify that to work
…On Sat, Sep 14 2024 at 00:25, Ioannis Papamanoglou < ***@***.*** > wrote:
***@***.**** commented on this pull request.
In src/faebryk/libs/sexp/dataclass_sexp.py (
#64 (comment) ) :
> @@ -181,6 +185,13 @@ def _decode[T](
if str(key) +
"s" in key_fields or str(key) in key_fields:
ungrouped_key_values.append(val)
continue
+
+
# The only symbol this is currently used for is the hide symbol in
schematics
Unfortunately that doesn't generalize :(
If a token is parsed as parseMaybeAbsentBool a token without braces is
evaluated to default and not true. There is (at least) one hide you are
dealing with that is not a parseMaybeAbsentBool and thus behaves
differently. We need to give for that one a hint to the parser in some
way.
Sidenote: Isn't it fine to mark it positional?
If not I would suggest making a new class (like with SymEnum).
—
Reply to this email directly, view it on GitHub (
#64 (comment) ) , or unsubscribe
(
https://github.com/notifications/unsubscribe-auth/ABALRKW5JN7O2B7M43UK2Y3ZWPQHXAVCNFSM6AAAAABOGCSBDCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMBUGM4TQNBUGA
).
You are receiving this because you authored the thread. Message ID: <atopile/faebryk/pull/64/review/2304398440
@ github. com>
|
mawildoer
force-pushed
the
mawildoer/kicad-schematic-exporter-4
branch
5 times, most recently
from
68a069e to
092cdd4
Compare
mawildoer
force-pushed
the
mawildoer/kicad-schematic-exporter-4
branch
from
092cdd4 to
b2cf760
Compare
iopapamanoglou
approved these changes
Sep 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the round-trip of all schematic artifacts clean.
Fuck this thing: https://gitlab.com/kicad/code/kicad/-/blob/b043f334de6183595fda935175d2e2635daa379c/eeschema/sch_io/kicad_sexpr/sch_io_kicad_sexpr_parser.cpp#L152-153
Fixes # (issue)
Checklist
Please read and execute the following:
Code of Conduct
By submitting this issue, you agree to follow our Code of Conduct: